wip: the fix may not be correct

mahrud · Feb 13, 2024 · 6cf43cf · 6cf43cf
1 parent 91b5599
commit 6cf43cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/M2/Macaulay2/packages/VirtualResolutions.m2 b/M2/Macaulay2/packages/VirtualResolutions.m2
@@ -126,12 +126,12 @@ virtualOfPair(Module, List) := ChainComplex => opts -> (M, alphas) -> (
     R := ring M;
     if M.cache.?resolution then return virtualOfPair(M.cache.resolution, alphas, opts);
     if any(alphas, alpha -> #alpha =!= degreeLength R) then error "degree has wrong length";
-    m := schreyerOrder gens gb presentation M;
+    m := schreyerOrder presentation M;
     m = submatrixWinnow(m, alphas, opts.Weights);
     i := 2;
     L := {m} | while m != 0 and i <= opts.LengthLimit list (
-        i = i + 1; m = map(R, rawKernelOfGB raw m); m = submatrixWinnow(m, alphas, opts.Weights));
-    L = apply(select(L, m -> m != 0), m -> modulo(complement cover m, m));
+        i = i + 1; m = syz m; -* minimize m; *- m = submatrixWinnow(m, alphas, opts.Weights));
+--    L = apply(select(L, m -> m != 0), m -> modulo(complement cover m, m));
     chainComplex L)
 virtualOfPair(ChainComplex, List) := ChainComplex => opts -> (F, alphas) -> (
     if any(alphas, alpha -> #alpha =!= degreeLength ring F) then error "degree has wrong length";

diff --git a/M2/Macaulay2/packages/VirtualResolutions/tests.m2 b/M2/Macaulay2/packages/VirtualResolutions/tests.m2
@@ -341,12 +341,18 @@ TEST /// -- test of returning -infinity for irrelevant ideals
   J = saturate(I, B);
 
   alphas = {{4,3} + {1,1}}
-  m = schreyerOrder gens gb presentation comodule J;
+  g = presentation comodule J;
+  m = schreyerOrder g;
   m = submatrixWinnow(m, alphas);
-  n = map(S, rawKernelOfGB raw m)
+--  n = map(S, rawKernelOfGB raw m);
+  n = syz m;
   n = submatrixWinnow(n, alphas);
+  --
   C = chainComplex{m, n}
   isVirtual(X, C) and C.dd^2 == 0
+  C.dd_2_{0}
+  C.dd
+
 
   m' = modulo(complement cover m, m)
   n' = modulo(complement cover n, n)