feat: add scripts for random uploads and wallet generation #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
approved these changes
Jun 14, 2024
|
|
||
| # Check for correct number of arguments | ||
| if [ "$#" -ne 2 ]; then | ||
| echo "Usage: $0 <number_of_wallets> <amount_per_wallet>" |
There was a problem hiding this comment.
if it requires arguments to be passed in,
better give an example of usage in the comment (head of this file, or in the readme correspondently?)
| # Initialize an array to store the wallet details | ||
| declare -a WALLETS | ||
|
|
||
| # Loop to create and fund wallets |
There was a problem hiding this comment.
I think the whole flow can be optimized to:
1, backup the wallet with balance
2, repeated create 5 wallets, collecting their address
3, restore the wallet with balance, transfer fund to new wallets one by one
Not a big issue, as anyway script do the job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts to simplify wallet creation and random data upload