feat(metrics): expose connected_peers, peers_in_rt and uptime metrics #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
commented
Jun 17, 2024
| @@ -589,7 +589,7 @@ impl NetworkBuilder { | |||
| listen_port: self.listen_addr.map(|addr| addr.port()), | |||
| is_client, | |||
| is_behind_home_network: self.is_behind_home_network, | |||
| connected_peers: 0, | |||
| peers_in_rt: 0, | |||
There was a problem hiding this comment.
This tracks the total number of peers in the RT rather than the "connections". So renamed it for clarity.
RolandSherwin
commented
Jun 17, 2024
| info!("Evicted old peer on new peer join: {old_peer:?}"); | ||
| self.send_event(NetworkEvent::PeerRemoved(peer, self.connected_peers)); |
There was a problem hiding this comment.
We were supposed to emit PeerRemoved(old_peer) instead of peer here.
RolandSherwin
force-pushed
the
move_metrics_from_rpc
branch
from
8b2b3c4 to
1d993a7
Compare
joshuef
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peers_in_rt,connected_peers,live_connectionsanduptime