fix(network): collect all spends and store the first two ordered spends #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
reviewed
Jun 18, 2024
joshuef
reviewed
Jun 18, 2024
| info!("For record {pretty_key:?} task {query_id:?}, found split record for a spend, accumulated and sending them as a single record"); | ||
| let accumulated_spends = accumulated_spends | ||
| .into_iter() | ||
| .take(2) |
There was a problem hiding this comment.
Can we keep a random magic number here for now, say 50? If so, might have to do the same during PUT validation (we store 2 there).
The lower bound of a single signed spend is 825B. Can grow if the inputs/outputs increase.
RolandSherwin
force-pushed
the
accumulate_double_spends
branch
from
87c34fa to
a5a5098
Compare
RolandSherwin
force-pushed
the
accumulate_double_spends
branch
from
a5a5098 to
d8ee017
Compare
maqi
reviewed
Jun 18, 2024
| .map_err(|_| NetworkError::InternalMsgChannelDropped)?; | ||
| } else { | ||
| sender | ||
| .send(Err(GetRecordError::SplitRecord { result_map })) |
There was a problem hiding this comment.
if no entry within the accumulated_record,
it shall be considered as NoHolders, instead of SplitRecord ?
There was a problem hiding this comment.
So we have no idea if the record we're GET'ing is a spend here, we just try to read the header and collect them IF they're spends. If not, we assume it is a chunk/register and just return SplitRecordError
RolandSherwin
force-pushed
the
accumulate_double_spends
branch
from
d8ee017 to
7bcd249
Compare
joshuef
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.