fix(network): validate spends even if we get did not get the majority #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
requested changes
Jul 5, 2024
grumbach
reviewed
Jul 5, 2024
sn_networking/src/transfers.rs
Outdated
| @@ -33,6 +33,7 @@ impl Network { | |||
| let get_cfg = GetRecordCfg { | |||
| get_quorum: Quorum::Majority, | |||
| retry_strategy: None, | |||
| // This should not be set. | |||
There was a problem hiding this comment.
Why? Maybe a longer comment would help?
maqi
approved these changes
Jul 5, 2024
RolandSherwin
force-pushed
the
spend_fix
branch
2 times, most recently
from
85d53d6 to
9341598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the PR buys us is that:
Quickly consolidate double spends attempts and store them in nodes. Clients were already safe, but nodes can possibly be out of sync for a while and would wait for replication to get them to sync. So it just reduces 1 step for the nodes