Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL PR VidosResolver example #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

toteto
Copy link
Collaborator

@toteto toteto commented Apr 23, 2024

VidosResolver Implementation: mailchain/js-iden3-auth#1

To get this example working while there is no js-iden3-auth lib published that includes VidosResolver

  1. Checkout the repository and branch of INTERNAL PR js-iden3-auth: VidosResolver js-iden3-auth#1
  2. In the js-iden3-auth do npm install, npm run build and npm link
  3. Checkout the example branch of vidos-resolver-example
  4. From the polygonid-tutorial-examples, cd into verifier-integration/js package, npm install and npm link @iden3/js-iden3-auth
  5. Add the VidosResolver resolver URL and API key in the .env file
  6. (down from here are same steps as before) Start ngrok with the app port.
  7. Start the application, if testing local start it with NODE_TLS_REJECT_UNAUTHORIZED="0" node . otherwise just node .
  8. Using the PolygonId wallet scan the QR code and provide proof

@toteto toteto requested a review from robdefeo April 23, 2024 18:17
@toteto toteto self-assigned this Apr 23, 2024
Copy link
Member

@robdefeo robdefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, this is a really good solution. Couple of small changes and let's get the other pull request merged.

Comment on lines 10 to 12
const VIDOS_RESOLVER_URL = undefined; // 'https://ugly-aqua-hummingbird-120.resolver.service.eu.vidos.local';
const VIDOS_API_KEY = undefined; // '24b500499e7c2f0a8634831d1b9894b74d656d3e7cd6de238d706c20a5db6d41';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some debug lines here

@@ -85,9 +89,10 @@ async function callback(req, res) {
ethURL,
contractAddress
);
const vidosResolver = VIDOS_RESOLVER_URL && VIDOS_API_KEY ? new VidosResolver(VIDOS_RESOLVER_URL, VIDOS_API_KEY) : undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a way to get the config inserted into these environment variables

},
});
const result = await response.json();
// console.log("root result", JSON.stringify(result, null, 2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably a debugging statement

@toteto toteto requested a review from robdefeo April 25, 2024 07:35
@toteto toteto changed the title Vidos resolver example INTERNAL PR VidosResolver example May 13, 2024
@toteto toteto requested a review from robdefeo May 13, 2024 11:38
Copy link
Member

@robdefeo robdefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, made a small change to remove specific endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants