Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notify.xml #5261

Closed
wants to merge 2 commits into from
Closed

Update notify.xml #5261

wants to merge 2 commits into from

Conversation

baimard
Copy link

@baimard baimard commented May 28, 2023

#5246 correction for this bug report

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@baimard baimard changed the base branch from master to staging May 28, 2023 20:00
@tomudding
Copy link
Contributor

For the Mailcow maintainers; as I pointed out in GH-5246 I think that a better longterm solution would be the removal of the notify extension/module and replace it with enotify (the command will still be notify).

This not only ensures that you cannot use a heavily deprecated function, it also makes it easier for people who like to use the sieve as they do not have to scour the internet in search for an RFC draft because the syntax they found in the Dovecot documentation does not match with the errors they receive from the sieve validation in Mailcow.

@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label Jul 28, 2023
@FreddleSpl0it FreddleSpl0it removed the stale Please update the issue with current status, unclear if it's still open/needed. label Aug 3, 2023
@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label Oct 2, 2023
@milkmaker milkmaker closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Please update the issue with current status, unclear if it's still open/needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants