Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/html-twig-templates Some miscellaneous HTML validation correction #6083

Closed
wants to merge 8 commits into from

Conversation

apio-sys
Copy link

Contribution Guidelines

What does this PR include?

Short Description

A few very simple miscellaneous HTML corrections in the /data/web/templates files. Ideally I would like to see the whole login page validate completely but there are a few items that can't really be fixed. autocorrect="off" is a non-standard attribute but can help on Apple/Safari browsers. <legend> seems wrongly used in a lot of places but simply removing it has severe styling implications. I fixed as much as possible other bits and pieces.

Affected Containers

Since this only affects files served from the Web UI, I guess only following (either/or) containers are affected

  • nginx-mailcow
  • php-fpm-mailcow

Did you run tests?

What did you test?

Checked page rendering of login page to make sure no adverse functionality or styling effect.

What were the final results?

No issues encountered.

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@apio-sys apio-sys changed the base branch from master to staging September 17, 2024 12:05
@DerLinkman
Copy link
Member

Please read the contribution guidelines and keep strait to them:

  1. You need to open up this PR against your fork of the staging branch.
  2. Keep the branch clear of any other changes which are not part of your work.

@DerLinkman DerLinkman closed this Oct 16, 2024
@DerLinkman DerLinkman added the not matching contrib guidelines Whenever a issue/pr is not matching the Guidelines this tag will assigned label Oct 16, 2024
@apio-sys apio-sys deleted the fix/html-twig-templates branch October 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not matching contrib guidelines Whenever a issue/pr is not matching the Guidelines this tag will assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants