deps: support OTel tracing v1.25.0 #191
Conversation
|
@inge4pres I've recently merged #194, which addresses updating Golang version to 1.21. Please update from Thanks for your contribution. |
| "github.com/sirupsen/logrus" | ||
| "github.com/uptrace/opentelemetry-go-extra/otellogrus" | ||
|
|
There was a problem hiding this comment.
nit: Should revert this unnecessary change.
There was a problem hiding this comment.
ah thanks, that's my IDE formatting imports, will do
There was a problem hiding this comment.
Oh, I see. It placed organizational imports in a 3rd section. That's a new thing with Golang. So it's not a mistake.
There was a problem hiding this comment.
Yeah, but there are 4 sections now.
Thank you for the amazing project given to the community! I rebased on most recent HEAD |
| "github.com/sirupsen/logrus" | ||
| "github.com/uptrace/opentelemetry-go-extra/otellogrus" | ||
|
|
There was a problem hiding this comment.
Oh, I see. It placed organizational imports in a 3rd section. That's a new thing with Golang. So it's not a mistake.
Signed-off-by: inge4pres <[email protected]>
There was a problem hiding this comment.
The test is failing due to a required change that goes with the OTel update. Apply this patch:
diff --git a/tracing/tracing.go b/tracing/tracing.go
index 7306a70..9831fb4 100644
--- a/tracing/tracing.go
+++ b/tracing/tracing.go
@@ -15,7 +15,7 @@ import (
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/sdk/resource"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
- semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
+ semconv "go.opentelemetry.io/otel/semconv/v1.24.0"
"go.opentelemetry.io/otel/trace"
"github.com/mailgun/holster/v4/errors"
Signed-off-by: inge4pres <[email protected]>
Thanks! 🙏🏼 just pushed |
|
Thanks for the guidance @Baliedge 🙏🏼 |
Reason for this PR
Addresses #189.
Details
Minor version upgrades to the OTel suites and implement the interface in
DummySpan.