-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update camera-streamer branch from master to main #137
Conversation
Hey, I'm sry that it took so long to get back to your PR. I'm really sry that I have to close this PR. We didn't have time to test the switch to main branch extensively and that's why we didn't want to merge it immediately. |
Looking at the apt octoprint github, it features no bookworm releases, only bullseye 32bit. camera-streamer 0.2.5 was added a couple months ago, so no "compile of up to date packages". |
Since my last comment a lot has happened, so here some updates:
Yes, you are right. There was some miscommunication internally about this. So here some corrections:
That's correct but there are mulitple reasons for that ig. One would be that camera-streamer is compiling now for one week on bookworm. Second thing is that Octoprint comes as some kind of all-in-one package/image. So as long as there won't be a bookworm Octoprint, there will be no package for it.
As I already mentioned above, Octoprint is an all-in-one image. As 64 bit nearly didn't have any usecase on bullseye with the Pis available, there was no reason for 64 bit image. This changes a bit with bookworm imo. Also the word use was a bit misleading. I meant we might directly use it or make a fork of it, to have more control over it. |
i did not meant to rant, just like to understand and assist if possible :) Thank you for the details |
Hi @mryel00 would it be possible to merge this change, but add a check so that the |
Hey @gjsmo, I'm already working on exactly that. As you can read in my comment on #191:
|
https://github.com/ayufan/camera-streamer recently changed the default branch name from
master
tomain
. From the README:The
master
branch is still present, but out-of-date, and missing features, such as being able to restrict the listening address.