Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update camera-streamer branch from master to main #137

Closed
wants to merge 1 commit into from

Conversation

twelho
Copy link

@twelho twelho commented Jul 3, 2023

https://github.com/ayufan/camera-streamer recently changed the default branch name from master to main. From the README:

Use main branch for semi-stable changes, or develop for experimental changes.

The master branch is still present, but out-of-date, and missing features, such as being able to restrict the listening address.

@mryel00
Copy link
Member

mryel00 commented Sep 13, 2023

Hey, I'm sry that it took so long to get back to your PR. I'm really sry that I have to close this PR. We didn't have time to test the switch to main branch extensively and that's why we didn't want to merge it immediately.
@KwadFan is already working for a while on a rewrite of crowsnest that will use precompiled binaries. self-compiling camera-streamer can make problems as you can see here #166
If we get permissions, we will use the repository of Octoprint that compiles always up to date packages. That's why we won't use the camera-streamer branch in future anymore and don't need this change.

@Surion79
Copy link

Hey, I'm sry that it took so long to get back to your PR. I'm really sry that I have to close this PR. We didn't have time to test the switch to main branch extensively and that's why we didn't want to merge it immediately. @KwadFan is already working for a while on a rewrite of crowsnest that will use precompiled binaries. self-compiling camera-streamer can make problems as you can see here #166 If we get permissions, we will use the repository of Octoprint that compiles always up to date packages. That's why we won't use the camera-streamer branch in future anymore and don't need this change.

Looking at the apt octoprint github, it features no bookworm releases, only bullseye 32bit. camera-streamer 0.2.5 was added a couple months ago, so no "compile of up to date packages".

@mryel00
Copy link
Member

mryel00 commented Oct 24, 2023

Since my last comment a lot has happened, so here some updates:

camera-streamer 0.2.5 was added a couple months ago, so no "compile of up to date packages".

Yes, you are right. There was some miscommunication internally about this. So here some corrections:
The version is updated a lot slower or is even pinned that makes sense that nothing breaks. It will only compile with the newest libcamera binaries, as an update to those would break it. I think that is also fixed, as the prebuilt packages come with binaries pakaged, but don't quote me on that ^^ I didn't yet have time to test libcamera version upgrades with that version.

it features no bookworm releases

That's correct but there are mulitple reasons for that ig. One would be that camera-streamer is compiling now for one week on bookworm. Second thing is that Octoprint comes as some kind of all-in-one package/image. So as long as there won't be a bookworm Octoprint, there will be no package for it.
These two things are just speculations about why that's like that. I don't have direct contact with the Octoprint devs.

only bullseye 32bit

As I already mentioned above, Octoprint is an all-in-one image. As 64 bit nearly didn't have any usecase on bullseye with the Pis available, there was no reason for 64 bit image. This changes a bit with bookworm imo.
Again these are only some speculations.

Also the word use was a bit misleading. I meant we might directly use it or make a fork of it, to have more control over it.
But as you might have already read inside #191 or #188, it will take some time for us to get to the point of using bookworm and something like a package repository.

@Surion79
Copy link

Since my last comment a lot has happened, so here some updates:

camera-streamer 0.2.5 was added a couple months ago, so no "compile of up to date packages".

Yes, you are right. There was some miscommunication internally about this. So here some corrections: The version is updated a lot slower or is even pinned that makes sense that nothing breaks. It will only compile with the newest libcamera binaries, as an update to those would break it. I think that is also fixed, as the prebuilt packages come with binaries pakaged, but don't quote me on that ^^ I didn't yet have time to test libcamera version upgrades with that version.

it features no bookworm releases

That's correct but there are mulitple reasons for that ig. One would be that camera-streamer is compiling now for one week on bookworm. Second thing is that Octoprint comes as some kind of all-in-one package/image. So as long as there won't be a bookworm Octoprint, there will be no package for it. These two things are just speculations about why that's like that. I don't have direct contact with the Octoprint devs.

only bullseye 32bit

As I already mentioned above, Octoprint is an all-in-one image. As 64 bit nearly didn't have any usecase on bullseye with the Pis available, there was no reason for 64 bit image. This changes a bit with bookworm imo. Again these are only some speculations.

Also the word use was a bit misleading. I meant we might directly use it or make a fork of it, to have more control over it. But as you might have already read inside #191 or #188, it will take some time for us to get to the point of using bookworm and something like a package repository.

i did not meant to rant, just like to understand and assist if possible :) Thank you for the details

@gjsmo
Copy link

gjsmo commented Oct 31, 2023

Hi @mryel00 would it be possible to merge this change, but add a check so that the main branch is only used on Bookworm? At the moment Crowsnest is unusable for many people who don't know much about Linux or coding. I understand you're working on a new build system, but this would be a very useful temporary fix. If you're concerned about stability (latest camera-streamer does work fine on an RPi 4 BTW, I have done multiple installations) then potentially add a warning banner.

@mryel00
Copy link
Member

mryel00 commented Oct 31, 2023

Hey @gjsmo, I'm already working on exactly that. As you can read in my comment on #191:

There will be soon an update to main branch, but Bookworm exclusive at first, as Crowsnest fails to build on Bookworm with master branch (#188). As we (more like me) currently think that the Bookworm Raspberry Pi image is more like in a testing phase for the software inside the klipper universe.
So we will only update it for Bookworm that those people with Bookworm can use Crowsnest again. The Bookworm people will be like a testing group for this. We won't release it for Bullseye as we want to do enough testing on it first that we can assure that there aren't any issues like breaking changes or maybe missing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants