Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide axis controls during print #1452

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

sddev0
Copy link
Contributor

@sddev0 sddev0 commented Jul 1, 2023

Description

This PR adds a setting to hide the axis controls (X, Y, Z) instead of only disabling it during a print. The Z-Offset controls are not affected. This saves some space on the screen, especially on mobile devices.

Mobile & Desktop Screenshots/Recordings

Settings:
Settings

Toolhead panel in ready state:
Ready

Toolhead panel in printing state with hiding setting on:
Printing_hide

Toolhead panel in printing state with hiding setting off:
Printing_disable

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
pl.json 10 0

Signed-off-by: Sebastian Duerholt <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0

Copy link
Member

@meteyou meteyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your PR. I added one comment. Pls fix this issue, then this PR is mergeable.

src/components/panels/ToolheadControlPanel.vue Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0

@meteyou meteyou added this to the v2.7.0 milestone Jul 12, 2023
@meteyou meteyou merged commit da15789 into mainsail-crew:develop Aug 7, 2023
@sddev0 sddev0 deleted the feature/hide-controls branch August 16, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants