Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): fix dismiss function for tmc warnings #1956

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(notifications): fix dismiss function for tmc warnings #1956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9880618
fix(notifications): fix dismiss function for tmc warnings
meteyou Jul 21, 2024
a351441
Merge branch 'develop' into fix/fix-dismiss-tmcwarnings
meteyou Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/store/gui/notifications/getters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,17 @@ export const getters: GetterTree<GuiNotificationState, any> = {
}
})

return notifications
// get all dismissed tmcwarnings and convert it to a string[]
const tmcwarningsDismisses = getters['getDismissByCategory']('tmcwarning').map(
(dismiss: GuiNotificationStateDismissEntry) => {
return dismiss.id
}
)

// return filtered tmcwarnings
return notifications.filter((entry) => {
return !tmcwarningsDismisses.includes(entry.id.substring(11))
})
},

getDismiss: (state, getters, rootState) => {
Expand Down
Loading