Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): add debug prefix #1973

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

nmaggioni
Copy link
Contributor

@nmaggioni nmaggioni commented Aug 14, 2024

Description

This PR implements a // debug: prefix for console messages that will have them displayed as greyed out. The implementation is based on the discussion had in #1950.

Related Tickets & Documents

Closes #1950.

Should this be mentioned in the docs? If so, where?

Mobile & Desktop Screenshots/Recordings

Examples generated with the following macro (RESPOND TYPE="command" MSG="debug: hello world" could have also been used):

[gcode_macro _LOG]
gcode:
  {action_respond_info("%s%s" % ("debug: " if params.DEBUG|default(0)|int == 1 else "", params.T))}

Before:

Old style output in the Console panel

After:

New style output in the Console panel

[optional] Are there any post-deployment tasks we need to perform?

N/A

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 17, 2024
@meteyou meteyou changed the title feat(console): add debug prefix (#1950) feat(console): add debug prefix Aug 17, 2024
@meteyou meteyou merged commit e0f5f78 into mainsail-crew:develop Aug 17, 2024
13 checks passed
@nmaggioni nmaggioni deleted the nm_console_debug_prefix branch August 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action messages in console are not greyed out
2 participants