Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): add support to sort locale json files #1976

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Aug 16, 2024

Description

This PR add prettier support to sort locale option files. It needs an plugin for that and this plugin will only be used in src/locale/*.json files.

Related Tickets & Documents

Weblate only add new keys/translations at the bottom of each object. With this feature, prettier can fix this issue.

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

It would be nice to add a CI workflow, that sorts Weblate PRs automatical.

@meteyou meteyou requested review from dw-0 and rackrick August 16, 2024 21:16
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 16, 2024
Signed-off-by: Stefan Dej <[email protected]>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
nl.json 293 18

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
nl.json 252 18

rackrick
rackrick previously approved these changes Aug 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2024
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
nl.json 252 18

Signed-off-by: Stefan Dej <[email protected]>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
da.json 6 8
es.json 0 17
fr.json 152 11
it.json 115 8
pl.json 180 9
ru.json 73 1
se.json 150 10

@meteyou meteyou merged commit cc584c0 into mainsail-crew:develop Aug 27, 2024
10 checks passed
@meteyou meteyou deleted the chore/add-locale-sort-prettier branch August 27, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants