Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webcam): fix some connection issues in Camera-Streamer #1981

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Aug 24, 2024

Description

This PR fix these WebRTC connection issues:

  • double connections
  • terminate session when backend is not available
  • start/stop when open/close panel on the dashboard
  • start stream in webcam page, when dashboard panel is closed

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 24, 2024
This will add a line in the console log, that the session is closed

Signed-off-by: Stefan Dej <[email protected]>
@meteyou meteyou changed the title fix(Camera-Streamer): fix some connection issues fix(webcam): fix some connection issues in Camera-Streamer Aug 25, 2024
@meteyou meteyou added this to the v2.13.0 milestone Sep 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 15, 2024
@meteyou meteyou merged commit f4ee321 into mainsail-crew:develop Sep 15, 2024
11 checks passed
@meteyou meteyou deleted the fix/camera-streamer-connections branch September 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants