-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Editor): fix editor width when sidebar is hidden #2014
fix(Editor): fix editor width when sidebar is hidden #2014
Conversation
Signed-off-by: Stefan Dej <[email protected]>
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request fixes the editor width issue when the file structure sidebar is hidden. The implementation involves updating the CSS classes in the TheEditor.vue component to ensure the editor takes up the full width when the sidebar is closed. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meteyou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Stefan Dej <[email protected]>
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meteyou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Description
This PR fix the width of the editor area, when the filestructur sidebar is closed.
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
before:
after:
[optional] Are there any post-deployment tasks we need to perform?
none
Summary by Sourcery
Fix the editor width issue by updating the CSS to handle the presence or absence of the file structure sidebar.
Bug Fixes: