Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Webcam): capitalize the connection state #2019

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 22, 2024

Description

This PR capitalize in MediaMTX and Camera-Streamer the state in the output.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Summary by Sourcery

Capitalize the connection state output in the WebrtcCameraStreamer and WebrtcMediaMTX components to improve the user interface consistency.

Bug Fixes:

  • Capitalize the connection state output in the WebrtcCameraStreamer and WebrtcMediaMTX components to ensure consistent display.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 22, 2024
Copy link
Contributor

sourcery-ai bot commented Sep 22, 2024

Reviewer's Guide by Sourcery

This pull request capitalizes the connection state in the output for MediaMTX and Camera-Streamer components. It modifies two Vue components to use a capitalize function for displaying the status.

File-Level Changes

Change Details Files
Capitalize the connection state in the output
  • Import the capitalize function from helpers
  • Add capitalize method to the component
  • Apply capitalize function to the status display
src/components/webcams/streamers/WebrtcCameraStreamer.vue
src/components/webcams/streamers/WebrtcMediaMTX.vue
Refactor WebrtcCameraStreamer component to use methods option
  • Move capitalize function to methods option in component decorator
  • Add capitalize property to the class
src/components/webcams/streamers/WebrtcCameraStreamer.vue

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@rackrick rackrick self-requested a review November 4, 2024 23:30
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@meteyou meteyou merged commit 0a72a7a into mainsail-crew:develop Nov 5, 2024
12 checks passed
@meteyou meteyou deleted the fix/webcam-status-output branch November 5, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants