Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORT-3] feat: add api and auth base code #3

Merged
merged 22 commits into from
Sep 23, 2024
Merged

[ORT-3] feat: add api and auth base code #3

merged 22 commits into from
Sep 23, 2024

Conversation

aube-dev
Copy link
Member

Description

  • API 호출 코드를 작성했습니다. (app/models/api.ts)
  • Cloudflare KV Cookie Session 기반 auth token 관리 코드를 작성했습니다. (server/models.auth.ts, entry.server.tsx)
  • Vite 방식의 환경 변수를 지원하도록 코드를 작성했습니다. (vite.config.ts, app/vite-env.d.ts, server/constants/env.ts)
  • 카카오 로그인 기능을 구현했습니다. (app/routes/oauth.kakao.tsx, app/routes/oauth.tsx)
  • 에러 로깅 도구인 Sentry를 연동했습니다.
  • Figma 디자인에 있는 error toast, loading indicator를 useFetcher, useFetchers 기반으로 구현했습니다.

Tech Specs

@aube-dev aube-dev requested review from Godbell and crew852 September 18, 2024 21:10
@aube-dev aube-dev self-assigned this Sep 18, 2024
Copy link

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying ort-storybook with  Cloudflare Pages  Cloudflare Pages

Latest commit: a749756
Status: ✅  Deploy successful!
Preview URL: https://f3d2ba3e.ort-storybook.pages.dev
Branch Preview URL: https://ort-3-api.ort-storybook.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying ort-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: a749756
Status: ✅  Deploy successful!
Preview URL: https://00984e24.ort-web.pages.dev
Branch Preview URL: https://ort-3-api.ort-web.pages.dev

View logs

Copy link
Contributor

@crew852 crew852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저로서는 트집을 잡을 수가 없군요
LGTM👍

@aube-dev aube-dev merged commit 736df0f into main Sep 23, 2024
3 checks passed
@aube-dev aube-dev deleted the ORT-3_api branch September 23, 2024 14:55
Copy link

sentry-io bot commented Sep 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'getSnapshot') routes/_index View Issue
  • ‼️ TypeError: defaultSearchParams.forEach is not a function routes/_index View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants