Update readme with isFullPageOrDatabase #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronovan
requested review from
a team and
kiranpandit
and removed request for
a team
rhart92
previously approved these changes
Aug 30, 2023
| // The page variable has been narrowed from | ||
| // PageObjectResponse | PartialPageObjectResponse | DatabaseObjectResponse | PartialDatabaseObjectResponse | ||
| // to | ||
| // PageObjectResponse | DatabaseObjectResponse. |
There was a problem hiding this comment.
I wonder if we should show / have our helpers be better at narrowing further. I think this is a good start though.
rhart92
approved these changes
Aug 30, 2023
rhart92
added a commit
that referenced
this pull request
Oct 3, 2023
* update readme with isfullpageordatabase * fix spacing * Fix formatting. --------- Co-authored-by: Ryan Hart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the example to be typed correctly, specific with isFullPageOrDatabase