Palloc #54
Draft
Palloc #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sploder12
reviewed
Feb 13, 2024
| uint64_t base; // base addr of mem. chunk | ||
| uint64_t len; // len of mem. chunk | ||
| uint32_t type; // what mem. chunk is used for | ||
| } |
There was a problem hiding this comment.
oh my goodness you forgot a ; !!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is NOT done. It contains what I've been working on thus far for a proper
Pallocfunction. With what is here, memory address ranges are appropriately stored in memory after some calls in the BIOS, and they are appropriately recognized once mOS starts booting in 32-bit mode.The next step is creating a structure for the OS to keep track of memory. It's been a while since we've had this discussion, but I believe we discussed using bitfields. My understanding is we could possibly use paging to optimize this, since we could remove the gaps between memory blocks and treat it as contiguous memory.
Additionally, there is an issue that I resolved in a kind of hacky way (see src/boot/detect_mem.asm:34). Typically, the BIOS command runs once, and then dumps a value which seems to indicate that the list is done. I don't think this is correct, so I hard-coded 10 iterations of the BIOS command based on observations of the memory addresses (the command repeats from the first chunk after it ends). This is obviously not ideal, and may even result in undefined behavior across systems.
Issue #30
Type of change
Testing
TODO
Test Configuration:
Checklist: