Named those two vga port constants #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sploder12
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Did some more digging on that Reddit thread and got to this page which describes the address and data ports for VGA in more depth. Your names are correct and good!
I think it would also be worthwhile to change the address bytes to macros as well! For example changing 0x0F to something like CURSOR_START.
Anyway, I'll approve this and let you merge your first PR! Merge when you're ready!
|
I don't have write access, I can't merge |
|
Oops... I forgot... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include any dependencies required for this change
Issue #
Type of change
Testing
Please describe tests that you ran to verify your changes. Provide instructions so that we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist: