Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2503] chore: remove line-through decoration from checked todo list items #5659

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[WEB-2503] chore: remove line-through decoration from checked todo list items #5659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/editor/src/styles/editor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,7 @@ ul[data-type="taskList"] li > div > p {

ul[data-type="taskList"] li[data-checked="true"] > div > p {
color: rgb(var(--color-text-400));
text-decoration: line-through;
text-decoration-thickness: 2px;
transition: color 0.2s ease;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we changing the color of checked items? Isn't the ticked checkbox enough?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are changing the text of checked items. Once something's done, we don't want to pay much attention to it, hence a muted text color. Removed the line-through as it was affecting the readability.

}
/* end to-do list */

Expand All @@ -264,7 +263,6 @@ ul[data-type="taskList"] li[data-checked="true"] > div > p {
transition: opacity 0.2s ease-out;
}


@keyframes spinning {
to {
transform: rotate(360deg);
Expand Down
Loading