Ad info update 2024 08 #2723
Open
Ad info update 2024 08 #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Error in using 'No Data' for an old delegate.
0xldr
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Note that the delegate migration process creates automatic links between delegate contracts without the need for updating folders like this. This is why 0x24419b100Bd4f5C581c0AA89A274fcfB5B3915a8 displays as Cloaky on the voting portal already:
The links appear to be stored in this file for use by the backened - https://github.com/makerdao/governance-portal-v2/blob/master/modules/migration/delegateAddressLinks.ts#L11
We strongly suggest that any changes to the folder structure are discussed with Jetstream before merging this Pull request.
Pkersfan88
approved these changes
Oct 2, 2024
Pkersfan88
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made:
@VoteWizard