docs(SDAO): add reasoning for safe unchecked blocks

makerdao · Sep 25, 2023 · f87cdb1 · f87cdb1
1 parent 775db2d
commit f87cdb1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/SDAO.sol b/src/SDAO.sol
@@ -199,6 +199,8 @@ contract SDAO {
 
         unchecked {
             balanceOf[msg.sender] = balance - value;
+            // Safe as the sum of all balances equals `totalSupply`;
+            // any overflow would have occurred already when increasing `totalSupply`
             balanceOf[to] += value;
         }
 
@@ -233,6 +235,8 @@ contract SDAO {
 
         unchecked {
             balanceOf[from] = balance - value;
+            // Safe as the sum of all balances equals `totalSupply`;
+            // any overflow would have occurred already when increasing `totalSupply`
             balanceOf[to] += value;
         }