Chore: update code and reports after audits #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amusingaxl
requested review from
0xp3th1um,
oddaf and
0xdecr1pto
and removed request for
0xp3th1um
The ownership of `DssVest` no longer lies with this module, instead it assumes that DssVest is already properly initialized and can be used to create vesting streams.
amusingaxl
changed the title
0xdecr1pto
reviewed
Sep 6, 2024
| @@ -54,6 +58,9 @@ contract Phase1b_UsdsSkyFarmingCheckScript is Script { | |||
| require(DssVestWithGemLike(vest).res(vestId) == 1, "DssVest/invalid-vest-res"); | |||
| require(DssVestWithGemLike(vest).usr(vestId) == dist, "DssVest/wrong-dist"); | |||
| require(DssVestWithGemLike(vest).mgr(vestId) == address(0), "DssVest/mgr-should-not-be-set"); | |||
| require(DssVestWithGemLike(vest).bgn(vestId) == vestBgn, "DssVest/invalid-bgn"); | |||
There was a problem hiding this comment.
Saw you add file(CAP) to the UsdsSkyFarmingInitSpell
There was a problem hiding this comment.
This is out of the scope of this repo.
Cap is a system parameter.
oddaf
approved these changes
Sep 6, 2024
oddaf
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.