Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add MKR poking #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat: add MKR poking #47

wants to merge 3 commits into from

Conversation

amusingaxl
Copy link

No description provided.

@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Oct 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@oddaf
Copy link
Member

oddaf commented Oct 2, 2024

Looks good sir. I think we should add the new pokes to the unit test.

Need to keep in mind the spotter poke will fail until the collateral is onboarded, maybe we can check if onboarded before testing it.

@amusingaxl
Copy link
Author

Just pushed some commits to update the address of the OSM and added test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddaf oddaf Awaiting requested review from oddaf

@0xdecr1pto 0xdecr1pto Awaiting requested review from 0xdecr1pto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amusingaxl @DaiFoundation-DevOps @oddaf