Op Farms #1
Op Farms #1
Conversation
v1.9.1
No need for farm check, minor changes Co-authored-by: telome <[email protected]>
|
|
Co-authored-by: sunbreak1211 <[email protected]>
| assertEq(dss.chainlog.getAddress("FARM_PROXY_TKA_TKB_BASE"), address(l1Proxy)); | ||
| assertEq(dss.chainlog.getAddress("REWARDS_DIST_TKA_TKB_BASE"), cfg.vestedRewardsDistribution); | ||
|
|
||
| l2Domain.relayFromHost(true); |
There was a problem hiding this comment.
Just consider this relayFromHost would also be executing the L2 side of the spell for the Bridge set up. Nothing really wrong with that but doesn't get isolated in the setupGateways function as was probably the intention.
There was a problem hiding this comment.
This code is the same as in arbitrum-farms.
For some reason when adding l2Domain.relayFromHost(false); at the end of setupGateways the test fails with a message of "revert: CrossDomainMessenger: message has already been relayed".
I think @telome saw something similar, but not sure.
There was a problem hiding this comment.
Ok yeah let's leave this open for now. It doesn't affect the audit as not in the scope anyway.
There was a problem hiding this comment.
Still not sure what exactly is the root cause of the issue but there seems to be some bug in foundry that causes the exit from setUp() to incorrectly restore the storage of OptimismDomain. For now a simple workaround could be to avoid using setUp(). For example, renaming setUp() to setUpFarm() and calling setUpFarm() at the beginning of distribute() avoids the issue.
Minor changes Co-authored-by: sunbreak1211 <[email protected]>
Co-authored-by: telome <[email protected]>
* Remove <= type(uint224).max check * stakingToken => l2StakingToken * Update lib/op-token-bridge
--------- Co-authored-by: telome <[email protected]>
No description provided.