Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fixes #6

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Audit fixes #6

merged 4 commits into from
Oct 12, 2023

Conversation

sunbreak1211
Copy link
Collaborator

No description provided.

@sunbreak1211 sunbreak1211 changed the title Add comments to explain why avoiding safe math checks Audit fixes Sep 19, 2023
@telome telome marked this pull request as ready for review September 19, 2023 14:29
oldchili
oldchili approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@oldchili oldchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunbreak1211
Copy link
Collaborator Author

@telome same here, it looks good to me.

telome
telome approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@telome telome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sunbreak1211 sunbreak1211 merged commit 2d675f8 into dev Oct 12, 2023
6 checks passed
@sunbreak1211 sunbreak1211 deleted the audit-fixes branch September 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telome telome telome approved these changes

@oldchili oldchili oldchili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunbreak1211 @telome @oldchili