Skip to content

Commit

Permalink
issue #155 - move Symfony integration into Bridge/Symfony subfolder
Browse files Browse the repository at this point in the history
  • Loading branch information
pounard committed Jun 4, 2024
1 parent 12ea694 commit 4e74c85
Show file tree
Hide file tree
Showing 9 changed files with 59 additions and 15 deletions.
31 changes: 31 additions & 0 deletions src/Bridge/Symfony/DbToolsBundle.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

declare (strict_types=1);

namespace MakinaCorpus\DbToolsBundle\Bridge\Symfony;

use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\Compiler\DbToolsPass;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\DbToolsExtension;

class DbToolsBundle extends Bundle
{
#[\Override]
public function build(ContainerBuilder $container): void
{
$container->addCompilerPass(new DbToolsPass());
}

/**
* Override is required for backward compatibility.
*
* Remove this method when MakinaCorpus\DbToolsBundle\DbToolsBundle legacy
* class will be removed.
*/
#[\Override]
protected function getContainerExtensionClass(): string
{
return DbToolsExtension::class;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

declare(strict_types=1);

namespace MakinaCorpus\DbToolsBundle\DependencyInjection\Compiler;
namespace MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\Compiler;

use MakinaCorpus\DbToolsBundle\Anonymization\Config\Loader\AttributesLoader;
use MakinaCorpus\DbToolsBundle\Anonymization\Config\Loader\YamlLoader;
use MakinaCorpus\DbToolsBundle\DependencyInjection\DbToolsConfiguration;
use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\DbToolsConfiguration;
use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace MakinaCorpus\DbToolsBundle\DependencyInjection;
namespace MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection;

use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
Expand Down Expand Up @@ -45,6 +45,7 @@ public function getConfigTreeBuilder(): TreeBuilder
throw throw new \InvalidArgumentException(\sprintf("Expected an int or valid date interval string value, got '%s'", \get_debug_type($v)));
};

// @phpstan-ignore-next-line
$treeBuilder
->getRootNode()
->children()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

declare(strict_types=1);

namespace MakinaCorpus\DbToolsBundle\DependencyInjection;
namespace MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection;

use MakinaCorpus\DbToolsBundle\Storage\FilenameStrategyInterface;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
use Symfony\Component\Config\Definition\ConfigurationInterface;

final class DbToolsExtension extends Extension
{
Expand All @@ -22,7 +22,7 @@ public function load(array $configs, ContainerBuilder $container): void
$configuration = $this->getConfiguration($configs, $container);
$config = $this->processConfiguration($configuration, $configs);

$loader = new YamlFileLoader($container, new FileLocator(\dirname(__DIR__).'/../config'));
$loader = new YamlFileLoader($container, new FileLocator(\dirname(__DIR__).'/Resources/config'));
$loader->load('services.yaml');

if (isset($config['storage_directory'])) {
Expand Down
File renamed without changes.
20 changes: 16 additions & 4 deletions src/DbToolsBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,27 @@

namespace MakinaCorpus\DbToolsBundle;

use MakinaCorpus\DbToolsBundle\DependencyInjection\Compiler\DbToolsPass;
use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DbToolsBundle as TheRealBundle;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Bundle\Bundle;

class DbToolsBundle extends Bundle
/**
* @deprecated
* This class is deprecated and will be remove in next major.
* @see \MakinaCorpus\DbToolsBundle\Bridge\Symfony\DbToolsBundle
*/
class DbToolsBundle extends TheRealBundle
{
#[\Override]
public function build(ContainerBuilder $container): void
{
$container->addCompilerPass(new DbToolsPass());
\trigger_deprecation(
'makinacorpus/db-tools-bundle',
'2.0.0',
"Class %s is deprecated and will be removed in next major version, please use %s instead.",
__CLASS__,
TheRealBundle::class,
);

parent::build($container);
}
}
2 changes: 1 addition & 1 deletion src/Helper/Cli/StandaloneConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace MakinaCorpus\DbToolsBundle\Helper\Cli;

use MakinaCorpus\DbToolsBundle\DependencyInjection\DbToolsConfiguration;
use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\DbToolsConfiguration;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class StandaloneConfiguration extends DbToolsConfiguration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

declare(strict_types=1);

namespace MakinaCorpus\DbToolsBundle\Tests\Unit\DependencyInjection;
namespace MakinaCorpus\DbToolsBundle\Tests\Unit\Bridge\Symfony\DependencyInjection;

use MakinaCorpus\DbToolsBundle\DependencyInjection\DbToolsConfiguration;
use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\DbToolsConfiguration;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\Yaml\Yaml;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

declare(strict_types=1);

namespace MakinaCorpus\DbToolsBundle\Tests\Unit\DependencyInjection;
namespace MakinaCorpus\DbToolsBundle\Tests\Unit\Bridge\Symfony\DependencyInjection;

use MakinaCorpus\DbToolsBundle\DependencyInjection\DbToolsExtension;
use MakinaCorpus\DbToolsBundle\Bridge\Symfony\DependencyInjection\DbToolsExtension;
use PHPUnit\Framework\Attributes\DependsExternal;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;
Expand Down

0 comments on commit 4e74c85

Please sign in to comment.