Remove forms dependency on 'extras' #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
forms_no_extras_dep
branch
from
0874e17 to
01b7d48
Compare
adamchainz
commented
Oct 1, 2024
| js = ['leaflet/leaflet.js'] + PLUGINS[PLUGIN_FORMS]['js'] | ||
| js = [ | ||
| 'leaflet/leaflet.js', | ||
| 'leaflet/leaflet.extras.js', |
There was a problem hiding this comment.
Re-adding the "extras" file here, because it's no longer coming from the form plugin dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #383. Avoid
<script src="/static/leaflet/leaflet.extras.js"></script>being rendered twice when theformsplugin is requested. This also fixes the syntax error since it avoids reusingimgPathElement, asleaflet.extras.jswould now only be included once.