implementation of multi threading + switch to requests lib for download #47
+116
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this! I confirm that tests pass on TravisCI. Coverallls is a false negative :/ Personnally I cannot spend time on a deep analysis of your code. But I know that @PeterSprague and @gutard are interested since they opened issues on this matter: Thanks again! |
| @@ -211,6 +238,9 @@ def __init__(self, url, layers, headers=None, tilesize=None, **kwargs): | |||
| if parse_version(self.wmsParams['version']) >= parse_version('1.3'): | |||
| projectionKey = 'crs' | |||
| self.wmsParams[projectionKey] = GoogleProjection.NAME | |||
| self.lock = threading.Lock() | |||
There was a problem hiding this comment.
since lock is private stuff, it's better if prefixed with underscore
There was a problem hiding this comment.
Indeed.
I'm having a bit of trouble to keep track of what is private and what is public as I haven't done python for quite a time and have done mostly c++/c# where it is clearly defined which are which.
…\'error\' attribute from TilesManager
…nt of number of threads + modified tests as needed
|
@gutard do you have feedback on this PR ? I scrolled a bit and it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.