Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataConverter class: Add reading logic for openPMD and numpy #530

Merged

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented May 31, 2024

This is supposed to make the transition from Numpy to openPMD more smooth as the DataConverter class can now be used to convert between Numpy and openPMD ad libitum.

TODO:

  • This logic only applies to the bare array. Since converting between Numpy and openPMD means that either the data source or sink has no metadata, there is no specific logic to write metadata, but instead only the bare array is taken care of. Further metadata must be defined by the user in the conversion script. Should we do more than that?
  • The example for now uses some local data that I have on my disk, use the sample data instead.
  • Maybe provide a bare CLI interface.

@RandomDefaultUser
Copy link
Member

Thanks for all the great work @franzpoeschel , I will be merging this now!

@RandomDefaultUser RandomDefaultUser merged commit 68f2a2d into mala-project:develop Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants