Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CI runs for normal PRs, but avoid runs for draft PRs #539

Conversation

DanielKotik
Copy link
Member

@DanielKotik DanielKotik commented Jun 6, 2024

Finally closes #514

Specifying if: ${{ ! github.event.pull_request.draft }} is only required for the first job in cpu-tests.yml and gh-paages.yml as subsequent jobs in the respective workflow files depend on the first job. This means that if the first job is skipped due to a PR draft, all dependent jobs are also skipped, which is what we intend.

image

@DanielKotik DanielKotik added the CI/CD Pipelines label Jun 6, 2024
@DanielKotik DanielKotik self-assigned this Jun 6, 2024
@DanielKotik DanielKotik marked this pull request as ready for review June 6, 2024 14:10
Copy link
Member

@RandomDefaultUser RandomDefaultUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@RandomDefaultUser RandomDefaultUser merged commit 8f9fbba into mala-project:develop Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid CI runs when PR is still in "draft" mode
2 participants