Secondary capture image spatial metadata #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steve Pieper <[email protected]> Allow IPP/IOP for SecondaryCaptureImageStorage
|
Rebasing on the |
thewtex
added a commit
to thewtex/ITK
that referenced
this pull request
Mar 15, 2024
Add patches to GDCM for reading pixel spacing, image orientation patient, image position patient, from DICOM secondary capture datasets in: malaterre/GDCM#167 which are based on GDCM `release`. xref: - malaterre/GDCM#158 - InsightSoftwareConsortium#4109 - Slicer/Slicer#7089 - InsightSoftwareConsortium#4111
Make this feature opt-in per the discussion: malaterre#158
thewtex
added a commit
to thewtex/ITK
that referenced
this pull request
Mar 18, 2024
This enables support for reading image orientation patient and image position patient from DICOM secondary capture images. This addresses needs such as reading Visibla Human DICOM color images in 3D Slicer: NA-MIC/ProjectWeek#875 and reading highdicom derived secondary capture DICOM in ITK-Snap: ImagingDataCommons/highdicom#247 The required patch has not yet been merged upstream: malaterre/GDCM#167 but is available in ITK-vendored GDCM, so condition enablement on NOT ITK_USE_SYSTEM_GDCM and provide a warning and pointer on where to find the patches for package managers and other redistributors that also the support.
malaterre
reviewed
Mar 21, 2024
malaterre
reviewed
Mar 21, 2024
Default to the GetSpacingTagFromMediaStorage, which is Nominal Scanned Pixel Spacing for Secondary Capture. Only use Pixel Spacing (0028,0030) when the SecondaryCaptureImagePlaneModule flag has been enabled on ImageHelper. Add documentation to Set/GetSecondaryCaptureImagePlaneModule accordingly.
|
Fixed issue with 0609129 thanks |
|
verified using: |
|
Thank you @malaterre |
|
FYI, this behavior (the optional presence of the ImagePlane Module and accompanying note about relationship of spacing attributes) is now standardized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #158