Check for Secondary Capture spacing following DICOM Part 3 Sect A.8.1.3 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the Secondary Capture Image IOD Module Note: > If Image Position (Patient) (0020,0032) and Image Orientation (Patient) (0020,0037) (from the Image Plane Module) are present, then the values of Pixel Spacing (0028,0030) (from the Image Plane Module and the Basic Pixel Spacing Calibration Macro included from the SC Image Module) are intended to be used for 3D spatial computations, rather than any values of Nominal Scanned Pixel Spacing (0018,2010) (from the SC Image Module), which may also be present. However, we make sure to throw a warning in `ImageHelper::GetSpacingTagFromMediaStorage` when the tag for a Secondary Capture MediaStorage is requested and SecondaryCaptureImagePlaneModule is enabled because returning a single tag is insufficient for this requirement. This function should not be called on this type of media storage. Co-authored-by: Mihail Isakov <[email protected]> Co-authored-by: Mathieu Malaterre <[email protected]> Co-authored-by: Steve Pieper <[email protected]>
thewtex
added a commit
to thewtex/ITK
that referenced
this pull request
Apr 11, 2024
…A.8.1.3 Following the Secondary Capture Image IOD Module Note: > If Image Position (Patient) (0020,0032) and Image Orientation (Patient) (0020,0037) (from the Image Plane M odule) are present, then the values of Pixel Spacing (0028,0030) (from the Image Plane Module and the Basic Pixel Spacing Calibration Macro included from the SC Image Module) are intended to be used for 3D spatial computations , rather than any values of Nominal Scanned Pixel Spacing (0018,2010) (from the SC Image Module), which may also be present. However, we make sure to throw a warning in `ImageHelper::GetSpacingTagFromMediaStorage` when the tag for a S econdary Capture MediaStorage is requested and SecondaryCaptureImagePlaneModule is enabled because returning a si ngle tag is insufficient for this requirement. This function should not be called on this type of media storage. Pushed upstream here: malaterre/GDCM#170 Co-authored-by: Mihail Isakov <[email protected]> Co-authored-by: Mathieu Malaterre <[email protected]> Co-authored-by: Steve Pieper <[email protected]>
hjmjohnson
pushed a commit
to InsightSoftwareConsortium/ITK
that referenced
this pull request
Apr 12, 2024
…A.8.1.3 Following the Secondary Capture Image IOD Module Note: > If Image Position (Patient) (0020,0032) and Image Orientation (Patient) (0020,0037) (from the Image Plane M odule) are present, then the values of Pixel Spacing (0028,0030) (from the Image Plane Module and the Basic Pixel Spacing Calibration Macro included from the SC Image Module) are intended to be used for 3D spatial computations , rather than any values of Nominal Scanned Pixel Spacing (0018,2010) (from the SC Image Module), which may also be present. However, we make sure to throw a warning in `ImageHelper::GetSpacingTagFromMediaStorage` when the tag for a S econdary Capture MediaStorage is requested and SecondaryCaptureImagePlaneModule is enabled because returning a si ngle tag is insufficient for this requirement. This function should not be called on this type of media storage. Pushed upstream here: malaterre/GDCM#170 Co-authored-by: Mihail Isakov <[email protected]> Co-authored-by: Mathieu Malaterre <[email protected]> Co-authored-by: Steve Pieper <[email protected]>
|
@thewtex I missed that note in my earliest attempt, I'll try to review the previous attempt to see if it still make sense to preserve it. thanks |
|
@malaterre thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Secondary Capture Image IOD Module Note:
However, we make sure to throw a warning in
ImageHelper::GetSpacingTagFromMediaStoragewhen the tag for a Secondary Capture MediaStorage is requested and SecondaryCaptureImagePlaneModule is enabled because returning a single tag is insufficient for this requirement. This function should not be called on this type of media storage.