Skip to content

Commit

Permalink
fix the export visibility
Browse files Browse the repository at this point in the history
  • Loading branch information
malkia committed Aug 11, 2024
1 parent e9ee8e2 commit 29217ce
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 51 deletions.
3 changes: 1 addition & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ build:windows --host_cxxopt=/std:c++17 --cxxopt=/std:c++17
#build:linux --cxxopt=-fvisibility=hidden --copt=-fvisibility=hidden
build:linux --dynamic_mode=off --fission=yes --copt=-g

#build:macos --cxxopt=-fvisibility=hidden
#build:macos --copt=-fvisibility=hidden
build:macos --cxxopt=-fvisibility=hidden --copt=-fvisibility=hidden
build:macos --dynamic_mode=off --fission=yes --copt=-g --action_env=CC=/opt/homebrew/bin/clang --host_action_env=CC=/opt/homebrew/bin/clang
# https://github.com/Homebrew/homebrew-core/issues/178435#issuecomment-2250615995
build:macos --linkopt=-L/opt/homebrew/opt/llvm/lib/c++ --linkopt=-L/opt/homebrew/opt/llvm/lib --linkopt=-lunwind
Expand Down
49 changes: 1 addition & 48 deletions all_sdk_includes.cc
Original file line number Diff line number Diff line change
@@ -1,51 +1,4 @@
#include <opentelemetry/sdk/metrics/meter_provider.h>
#include <opentelemetry/sdk/metrics/exemplar/fixed_size_exemplar_reservoir.h>
#include <opentelemetry/sdk/metrics/exemplar/no_exemplar_reservoir.h>

#include <opentelemetry/sdk/logs/logger_provider.h>
#include <opentelemetry/sdk/logs/logger_provider_factory.h>
#include <opentelemetry/sdk/logs/event_logger_provider.h>
#include <opentelemetry/sdk/logs/event_logger_provider_factory.h>
#include <opentelemetry/sdk/logs/simple_log_record_processor.h>
#include <opentelemetry/sdk/logs/batch_log_record_processor.h>
#include <opentelemetry/sdk/logs/simple_log_record_processor.h>
#include <opentelemetry/sdk/logs/simple_log_record_processor_factory.h>

#include <opentelemetry/sdk/trace/tracer_provider.h>
#include <opentelemetry/sdk/trace/simple_processor_factory.h>
#include <opentelemetry/sdk/trace/tracer_provider_factory.h>
#include <opentelemetry/sdk/trace/batch_span_processor_factory.h>

#include <optional>

#if defined(_MSC_VER)
#include <opentelemetry/exporters/etw/etw_logger.h>
#include <opentelemetry/exporters/etw/etw_tracer.h>
#endif

void OPENTELEMETRY_EXPORT otel_sdk_all_sdk_includes()
{
using namespace opentelemetry::sdk;
{
[[maybe_unused]] std::optional<metrics::MeterProvider> t0;
[[maybe_unused]] std::optional<metrics::FixedSizeExemplarReservoir> t1;
[[maybe_unused]] std::optional<metrics::NoExemplarReservoir> t2;
metrics::ExemplarReservoir::GetNoExemplarReservoir();
}
{
[[maybe_unused]] std::optional<logs::LoggerProvider> t0;
[[maybe_unused]] std::optional<logs::EventLoggerProvider> t1;
[[maybe_unused]] std::optional<logs::SimpleLogRecordProcessor> t2;
[[maybe_unused]] std::optional<logs::BatchLogRecordProcessor> t3;
logs::EventLoggerProviderFactory::Create();
std::unique_ptr<logs::LoggerContext> t4;
logs::LoggerProviderFactory::Create(std::move(t4));
std::unique_ptr<logs::LogRecordExporter> t5;
logs::SimpleLogRecordProcessorFactory::Create(std::move(t5));
}
{
trace::SimpleSpanProcessorFactory::Create({});
[[maybe_unused]] std::unique_ptr<trace::SpanProcessor> t0;
trace::TracerProviderFactory::Create(std::move(t0));
}
}
#endif
2 changes: 1 addition & 1 deletion api/include/opentelemetry/common/macros.h
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ point.
# else
# define OPENTELEMETRY_EXPORT __attribute__((visibility("default")))
# if defined(__clang__)
# define OPENTELEMETRY_EXPORT_TYPE __attribute__((type_visibility("default")))
# define OPENTELEMETRY_EXPORT_TYPE __attribute__((visibility("default"))) __attribute__((type_visibility("default")))
# else
# define OPENTELEMETRY_EXPORT_TYPE __attribute__((visibility("default")))
# endif
Expand Down

0 comments on commit 29217ce

Please sign in to comment.