-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug when export html, chart plotly not show #79
base: master
Are you sure you want to change the base?
Conversation
Hi @quangduong109 thanks for the work and PR! Before we can merge, can you please:
|
I have updated. Please check and accept this pull request. Thank you ^^ |
Hi @quangduong109, thanks, though you haven't squashed your commits - there should only be 1 commit to be merged. Though more importantly, I've just checked out your branch and plotly appears to still be broken, as seen when generating the docs via |
Because the DOM has not finished loading, the require plotly function fails, in fact the require function is an async function, so it cannot be assigned to the Plotly variable.
The fix is to replace the text in the returned plot function to pass the Plotly variable into the render chart function.
Before fix: