Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulletproofing the RomeoAndJuliet exercise from hacky solutions. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hristog
Copy link

@hristog hristog commented Jun 25, 2017

An example of a possible abuse can be found here: d7c34a7.

Note:

  • Quite a bit more elegant bulletproofing could be achieved via employing metaclasses and descriptors (thus, avoiding the annoying copy-and-paste's to replicate functionality) - if this PR gets accepted, I'll create a further commit implementing the improved version.
  • The module imports (i.e., referring to Exercises instead of Advanced) on your master branch are probably outdated.
  • The strange whitespace edits/replacements in arbitrary locations - outside of the intended ones only - within the edited files my commits have been created automatically, just by the mere virtue of editing the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant