Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaprWorkflowClient doesn't use specified ports #66

Open
sclarke81 opened this issue Oct 25, 2024 · 1 comment
Open

DaprWorkflowClient doesn't use specified ports #66

sclarke81 opened this issue Oct 25, 2024 · 1 comment
Assignees
Milestone

Comments

@sclarke81
Copy link

Expected Behavior

To be able to use the DaprWorkflowClient with DaprSidekick.

Actual Behavior

The DaprWorkflowClient is created during initialisation (unlike the DaprClient which is created on first use). This means that it looks for the DAPR_GRPC_PORT and DAPR_HTTP_PORT environment variables. These env vars haven't been set yet though because they're only set when sidekick starts the sidecar. Perhaps the env vars could be set earlier?

Steps to Reproduce the Problem

Use Dapr Workflows and Sidekick with a non-default HTTP and GRPC sidecar port numbers.

Release Note

RELEASE NOTE:

badgeratu added a commit that referenced this issue Oct 26, 2024
@badgeratu badgeratu self-assigned this Oct 26, 2024
@badgeratu
Copy link
Contributor

badgeratu commented Oct 26, 2024

Hi, appreciate this is an issue. Have started looking at it now. I agree first step is to at the very least respect the DAPR_GRPC_PORT and DAPR_HTTP_PORT environment variables as a pass-through if set externally before startup - that will ensure Sidekick and the Workflow client use the same values. I've brought in the .NET SDK WorkflowConsoleApp sample which is a pretty good starting point and made some changes to make that work properly, which hopefully is a step in the right direction.

I'll have a think next about how we can maybe do something better in the bootstrap/startup of Sidekick. It's a bit challenging when it's all in the same IServiceCollection container to constrain an order on things but maybe there's something we can do.

I've also read through the #workflow thread on Discord and seen the challenges you've been facing. Just want to say thank you so much for persevering with Sidekick!

@badgeratu badgeratu added this to the 2.0.0 milestone Oct 26, 2024
badgeratu added a commit that referenced this issue Nov 3, 2024
badgeratu added a commit that referenced this issue Nov 3, 2024
…app-port to be suppressed (#68)

* #66 : Workflow sample, respect external Environment Variables on startup, allow AppPort to be ignored

* #66 : Always initialize DaprOptions to ensure valid fluent builder initalization

* #66 : Unit test for HasAppPort, other cleanup

* #66 : Additional unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants