Respect DAPR_GRPC_PORT environment variable if set externally, allow app-port to be suppressed #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its now possible to define the environment variable
DAPR_GRPC_PORT
externally and Sidekick will use it to override the auto-calculated port for the sidecar. This allows the Workflow client to use the same port as the Sidecar. Note that it will also override any defined port inappsettings.json
, this is in keeping with the way ASP.NET Core default builder configurations work.Additionally as a pure-workflow application does not need to expose an AppPort, the
HasAppPort
option has been added to allow theapp-port
command-line option to be suppressed.To verify this operation the WorkflowConsole sample from the Dapr
dotnet-sdk
has been added to the solution, and demonstrates the expected operation.Finally the
CheckHealthAsync()
method has been added toIDaprProcessHost
, so thatIDaprSidecarHost
can be used to check the sidecar health/availability on startup in a similar way to howDaprClient
would be used.Issue reference
#66
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: