Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git port #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Dennisbonke
Copy link
Member

@Dennisbonke Dennisbonke commented Jul 16, 2021

This PR adds an initial port of git. Some notable features that are not yet working are pull and clone, but git log does work.

Blocked on managarm/mlibc#292
Blocked on managarm/managarm#482 and managarm/mlibc#750

@avdgrinten
Copy link
Member

Do commands on local repositories work? (For example after copying a repository into the sysroot?) Stuff like git add, git status, git commit?

@Dennisbonke
Copy link
Member Author

I haven’t tried git add recently so I can’t tell you that, I know that git log and git diff seem to work and from what I remember was git status broken at this time.

@Dennisbonke
Copy link
Member Author

I just checked, git status is broken on the lack of an setitimer() implementation, git diff works (albeit slow), git log works fine, git add seems to work fine, git commit works too (after setting the identity with git config), git reset --hard fails on setitimer() too and so does git checkout HEAD~1. Anything else you want me to test before merging?

@Dennisbonke
Copy link
Member Author

It seems like serenity patches out several calls to setitimer, which we might be able to use to get more commands working.

@avdgrinten
Copy link
Member

I'm not a fan of doing that; we should just implement POSIX timers.

@Dennisbonke
Copy link
Member Author

I agree on the not a fan part, however, do we want to block this port on that? If yes, then I'll mark this one as a draft waiting on POSIX timers.

Signed-off-by: Dennis Bonke <[email protected]>
@Dennisbonke
Copy link
Member Author

I agree on the not a fan part, however, do we want to block this port on that? If yes, then I'll mark this one as a draft waiting on POSIX timers.

This has been resolved, setitimer and friends are sysdeps which Managarm doesn't implement. git is fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants