Add snappy, libx264, opus, libvpx, ffmpeg, lcms, re2 #211
Conversation
Signed-off-by: Dennis Bonke <[email protected]>
Signed-off-by: Dennis Bonke <[email protected]>
Dennisbonke
force-pushed
the
yes-i-have-even-more-ports
branch
from
91ac652
to
53a39c3
Compare
Signed-off-by: Dennis Bonke <[email protected]>
Signed-off-by: Dennis Bonke <[email protected]>
Signed-off-by: Dennis Bonke <[email protected]>
Signed-off-by: Dennis Bonke <[email protected]>
Signed-off-by: Dennis Bonke <[email protected]>
Dennisbonke
force-pushed
the
yes-i-have-even-more-ports
branch
from
53a39c3
to
6ebd5eb
Compare
avdgrinten
changed the title
| - '--arch=@OPTION:arch@' | ||
| - '--cross-prefix=@OPTION:arch-triple@' | ||
| - '--host-cc=gcc' | ||
| - '--target-os=linux' # Fun times ahead |
There was a problem hiding this comment.
Why don't we add a target for Managarm?
There was a problem hiding this comment.
Probably me being lazy and it seems to work out fine, so no need to add extra patchwork that needs to be upstreamed eventually.
| -#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT) | ||
| +#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT) && !defined(__managarm__) |
There was a problem hiding this comment.
We don't implement this yet (or at least we didn't at the time of me porting ffmpeg).
There was a problem hiding this comment.
mlibc has it stubbed, but managarm currently does not implement this. This would have to be implemented as a new hel call IIRC.
There was a problem hiding this comment.
We should add the required infrastructure to mlibc (if it doesn't exist already) and make the Managarm sysdeps return ENOSYS (and log a message).
| -#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT) | ||
| +#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT) && !defined(__managarm__) |
There was a problem hiding this comment.
mlibc has it stubbed, but managarm currently does not implement this. This would have to be implemented as a new hel call IIRC.
All of these ports are split off from #178, and as far as I can tell should just be good to go.
The following ports have been added:
snappy;libx264;opus;libvpx;ffmpeg;lcms;re2.