Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Documentation #158

wants to merge 2 commits into from

Conversation

tinajn
Copy link
Contributor

@tinajn tinajn commented Mar 23, 2023

  • Update README.md to mention pre-release of Python 3 port
  • Remove Visual C++ pre-requisite from developing.md
  • Remove pydivert v2.0.9 requirement from release binary building documentation. Latest version of pydivert (v2.1.0) worked with pyinstaller.

@tinajn
Update Documentation
cf6523a 
* Remove Visual C++ pre-requisite from developing.md
* Remove pydivert v2.0.9 requirement from release binary
  building documentation. Latest version of pydivert
  (v2.1.0) worked with pyinstaller.
mr-tz
mr-tz reviewed Mar 23, 2023
View reviewed changes
README.md
Comment on lines +23 to +24
The current version, 3.0 (alpha), is a pre-release of the Python 3 port of FakeNet-NG.
If you encounter any bugs in this version, please report them via GitHub issues.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

docs/developing.md
* Python 2.7 x86 with `pip`
* Visual C++ for Python 2.7 development, available at:
<https://aka.ms/vcpython27>
* Python 3.7.x x86 with `pip`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only Python 3.7 or >=3.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned 3.7 because that's what we have tested with. Since support for 3.7 is ending soon, we have plans to move on to 3.10+ in the near future at which point I think this line can be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinajn @mr-tz