New line following algo #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_ros into new_line_following
CullenSUN
reviewed
Aug 22, 2024
| return '', '' | ||
|
|
||
|
|
||
| class LineResponse(Node): |
There was a problem hiding this comment.
Suggested change
| class LineResponse(Node): | |
| class LineDetectionNode(Node): |
|
|
||
| self.get_logger().info(f"Linear: {linear}\nAngular: {angular:.2f}") | ||
|
|
||
| message1 = String() |
There was a problem hiding this comment.
better create a custom message to contain both fields
mangdangroboticsclub
merged commit ada2bae
into
mangdangroboticsclub:ros2-dev
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the algo for line following to resolve delay issue