-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
able to set mintFees for lazyClaim #101
base: main
Are you sure you want to change the base?
Conversation
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
sidenote - is it possible there's an existing bug with insufficient funds check in _transferFunds that isn't inclusive of the mintfee?
This is not a good PR. We need to store the mint fee in the claim itself so we don't rug old claims when the fee changes. |
We need to store it efficiently in the claim. How many bits do we have left? Can we be smart and store in gwei instead of wei to reduce the amount of bits we need? |
packages/manifold/contracts/lazyclaim/ERC1155LazyPayableClaim.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See all my comments.
|
hmm I thought creator-core-extensions-solidity/packages/manifold/contracts/lazyclaim/LazyPayableClaim.sol Line 103 in e2be17d
|
This PR
We want to be able to set Manifold mint fees dynamically. Use case is for polygon network, MATIC cost is different than ETH so we need to be able to accoun and set the fees however we like.
The changes are:
setMintFees
toLazyPayableClaim
. This is gated byadminRequired
modifierScreenshots (if applicable)
Ticket
https://linear.app/manifoldxyz/issue/UPDATE-THIS-PART
Self-Review
CR Notes
QA Steps