-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for Milestone 1: Adding the page-color-scheme #17
base: main
Are you sure you want to change the base?
PR for Milestone 1: Adding the page-color-scheme #17
Conversation
…fold scheme utility classes
linking first pass review for reference tingting-lwy#1 (review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! if anything needs improvement, it would be putting the widgetTheme
options as a default for any widget, so we wouldn't need to redefine the prop in each newly added widget config. for now, this is sufficient.
interface WidgetThemeDefinition { | ||
value: string; | ||
options: WidgetPropOptions[]; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works -- was thinking since we have set values for the theme
stuff (the scheme utility classes), we can be more explicit about what a theme is.
PR for Milestone 1: Adding the page-color-scheme
An example of the dark theme:
An example of the light theme