-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 2: Adding data-media-background prop #18
base: main
Are you sure you want to change the base?
Milestone 2: Adding data-media-background prop #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as intended, with a minor bug on the generated code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits remaining. overall, seems good to merge.
config?.type === WidgetPropType.ARRAY | ||
" | ||
> | ||
<label id="multipleInputs"> colors example: red, blue </label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just caught this this time around -- if there are more config props with type = ARRAY
, you would have multiple labels with the same id + placeholder test. that wouldn't be good for accessibility issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true! I actually decided I didn't need to ID this label since any labels created by config props with type = ARRAY
would then be styled using the selector label
rather than creating accessibility issues by potentially using same ids
@@ -321,4 +409,9 @@ export default class Configurator extends Vue { | |||
word-wrap: break-word; | |||
overflow: auto; | |||
} | |||
label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment: if anyone were to add a label
element to the configurator, it would be styled using the rules below.
Milestone 2: Adding the page-color-scheme
Edge Cases tested:
Here is an example of an image
Here is an example of a singular color:
Here is an example of gradient colors:
Here is an example of gradient colors using other CSS valid values: