Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded external overrideAllowed method #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emo-eth
Copy link

@emo-eth emo-eth commented May 26, 2023

The original overrideAllowed is strange in that it's a view method that always uses the caller – making it impractical for debugging registry override issues without scripting tools. This adds a second method with the signature

function overrideAllowed(address tokenAddress, address caller) external view returns (bool);

to mitigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants