Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage Tangent Between Circles #36

Merged
merged 3 commits into from
Oct 11, 2018
Merged

Increase coverage Tangent Between Circles #36

merged 3 commits into from
Oct 11, 2018

Conversation

giancarloGiuffra
Copy link
Contributor

Issue #30
100% coverage of tangent_between_circles.js

@manrajgrover manrajgrover self-requested a review October 11, 2018 17:50
manrajgrover
manrajgrover approved these changes Oct 11, 2018
View reviewed changes
Copy link
Owner

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Thanks @giancarloGiuffra!

@manrajgrover manrajgrover merged commit 51fe89e into manrajgrover:master Oct 11, 2018
@giancarloGiuffra giancarloGiuffra deleted the increase-coverage-tangent-between-circles branch October 11, 2018 20:30
@giancarloGiuffra
Copy link
Contributor Author

happy to contribute, this was actually my first PR to an open source project :)

@manrajgrover
Copy link
Owner

@giancarloGiuffra That's really impressive! Congratulations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manrajgrover manrajgrover manrajgrover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giancarloGiuffra @manrajgrover