Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix typed field ref#27 #29

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Conversation

mansenfranzen
Copy link
Owner

Addresses #27

@mansenfranzen mansenfranzen added the bug Something isn't working label Jul 27, 2021
@mansenfranzen mansenfranzen self-assigned this Jul 27, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 27, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.18%.

Quality metrics Before After Change
Complexity 0.12 ⭐ 0.20 ⭐ 0.08 👎
Method Length 68.14 🙂 66.06 🙂 -2.08 👍
Working memory 4.94 ⭐ 5.33 ⭐ 0.39 👎
Quality 78.65% 78.47% -0.18% 👎
Other metrics Before After Change
Lines 371 393 22
Changed files Quality Before Quality After Quality Change
docs/source/conf.py 75.21% ⭐ 75.21% ⭐ 0.00%
sphinxcontrib/autodoc_pydantic/init.py 77.94% ⭐ 77.29% ⭐ -0.65% 👎
tests/test_edgecases.py 82.63% ⭐ 81.92% ⭐ -0.71% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
sphinxcontrib/autodoc_pydantic/init.py add_configuration_values 0 ⭐ 342 ⛔ 4 ⭐ 66.33% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@mansenfranzen mansenfranzen merged commit 29b0e4e into main Aug 18, 2021
@mansenfranzen mansenfranzen deleted the bug_fix_typed_field_ref#27 branch August 18, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant